Skip to content

expression: pushdown reverse to TiFlash#35738

Merged
ti-chi-bot merged 15 commits intopingcap:masterfrom
lizhenhuan:master
Jul 13, 2022
Merged

expression: pushdown reverse to TiFlash#35738
ti-chi-bot merged 15 commits intopingcap:masterfrom
lizhenhuan:master

Conversation

@lizhenhuan
Copy link
Contributor

@lizhenhuan lizhenhuan commented Jun 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35754

Problem Summary:
Related Issue: Implements pushdown reverse to TiFlash
pingcap/tiflash#5111
#35754

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support to pushdown reverse to TiFlash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 25, 2022

Welcome @lizhenhuan!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@lizhenhuan lizhenhuan mentioned this pull request Jun 25, 2022
Merged
12 tasks
@lizhenhuan
Merge pull request #2 from pingcap/master
947b2bc 
Merge from PingCAP Repo
@sre-bot
Copy link
Contributor

sre-bot commented Jul 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/709ae4e74892f419c4d3483d30fe376faeffa589

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2022
@mengxin9014
Copy link
Contributor

mengxin9014 commented Jul 5, 2022

LGTM

ywqzzy
ywqzzy reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add tests in planner/core/integration_test.go, you can ref to this pr #35739.

@lizhenhuan
Merge pull request #3 from pingcap/master
bd05be6 
Merge from pingcap repo
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2022
XuHuaiyu
XuHuaiyu reviewed Jul 12, 2022
View reviewed changes
planner/core/integration_test.go
rows := [][]interface{}{
{"TableReader_9", "root", "data:ExchangeSender_8"},
{"└─ExchangeSender_8", "mpp[tiflash]", "ExchangeType: PassThrough"},
{" └─Projection_4", "mpp[tiflash]", "reverse(test.t.a)->Column#3"},
Copy link
Contributor

@XuHuaiyu XuHuaiyu Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to test both ScalarFuncSig_ReverseUTF8 and ScalarFuncSig_Reverse

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jul 12, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022

@XuHuaiyu: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lizhenhuan
Copy link
Contributor Author

lizhenhuan commented Jul 13, 2022

/run-check_dev

@lizhenhuan
Copy link
Contributor Author

lizhenhuan commented Jul 13, 2022

/run-check_dev_2

@lizhenhuan lizhenhuan requested a review from ywqzzy July 13, 2022 02:53
@zanmato1984
Copy link
Contributor

zanmato1984 commented Jul 13, 2022

/lgtm

zanmato1984
zanmato1984 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jul 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dc0bae7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022
@ti-chi-bot ti-chi-bot merged commit 7c45e67 into pingcap:master Jul 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 13, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 2, success 34, total 36 24 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@ywqzzy ywqzzy Awaiting requested review from ywqzzy

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implements pushdown reverse to TiFlash

7 participants

@lizhenhuan @ti-chi-bot @sre-bot @mengxin9014 @XuHuaiyu @zanmato1984 @ywqzzy