Skip to content

planner: disable collate clause support for enum or set column (#35684)#35729

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.4from
ti-srebot:release-5.4-11f06e00ce72
Closed

planner: disable collate clause support for enum or set column (#35684)#35729
ti-srebot wants to merge 1 commit intopingcap:release-5.4from
ti-srebot:release-5.4-11f06e00ce72

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 24, 2022 •
edited
Loading

cherry-pick #35684 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35729

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35729:release-5.4-11f06e00ce72

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #31637

Problem Summary:
We can't cast enum or set currently, there is no way to implement collate clause support for enum or set column.
So this PR makes TiDB returns an error instead of panic.

What is changed and how it works?

Return an error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016 @ti-srebot
cherry pick pingcap#35684 to release-5.4
1c58552 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 24, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 24, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick labels Jun 24, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2022
@ti-srebot ti-srebot added this to the v5.4.1 milestone Jun 24, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 24, 2022

@wjhuang2016 you're already a collaborator in bot's repo.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 27, 2022
@ti-chi-bot ti-chi-bot closed this Feb 17, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2025

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta Awaiting requested review from tangenta

@winoros winoros Awaiting requested review from winoros

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees

@wjhuang2016 wjhuang2016

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.4-cherry-pick

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @VelocityLight @wjhuang2016