Skip to content

BR: fix backup ranges total time summary log (#35552)#35702

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.1from
ti-srebot:release-6.1-3c83cd310603
Jun 26, 2023
Merged

BR: fix backup ranges total time summary log (#35552)#35702
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.1from
ti-srebot:release-6.1-3c83cd310603

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 23, 2022 •
edited
Loading

cherry-pick #35552 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35702

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35702:release-6.1-3c83cd310603

What problem does this PR solve?

Issue Number: close #35553

Problem Summary: Incorrect total time summary log of backup ranges process

[2022/06/16 00:03:22.387 -04:00] [INFO] [client.go:567] ["Backup Ranges"] [take=67ns]

What is changed and how it works?

Fix the code of printing the log. After fixed, it shows the correct time for backup ranges.

[2022/06/16 00:17:02.284 -04:00] [INFO] [client.go:538] ["Backup Ranges"] [take=595.572234ms]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ixuh12 @ti-srebot
cherry pick pingcap#35552 to release-6.1
3360e61 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2022
Merged
12 tasks
@ti-srebot ti-srebot added component/br This issue is related to BR of TiDB. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.1-cherry-pick labels Jun 23, 2022
@ti-srebot ti-srebot requested review from 3pointer and joccau June 23, 2022 15:15
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2022

@joccau you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3360e61cb72c69e6a701059f9800bccf398829e4

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Aug 19, 2022
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-26 05:41:15.276109464 +0000 UTC m=+599840.677359896: ☑️ agreed by 3pointer.
  • 2023-06-26 05:41:53.44928622 +0000 UTC m=+599878.850536670: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7e00dc2 into pingcap:release-6.1 Jun 26, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

@joccau joccau Awaiting requested review from joccau

Assignees

@joccau joccau

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.1-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ti-srebot @ti-chi-bot @sre-bot @3pointer @Leavrth @VelocityLight @joccau @ixuh12