Skip to content

BR: fix backup ranges total time summary log (#35552)#35701

Closed
ti-srebot wants to merge 1 commit intopingcap:release-6.0from
ti-srebot:release-6.0-3c83cd310603
Closed

BR: fix backup ranges total time summary log (#35552)#35701
ti-srebot wants to merge 1 commit intopingcap:release-6.0from
ti-srebot:release-6.0-3c83cd310603

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 23, 2022 •
edited
Loading

cherry-pick #35552 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35701

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35701:release-6.0-3c83cd310603

What problem does this PR solve?

Issue Number: close #35553

Problem Summary: Incorrect total time summary log of backup ranges process

[2022/06/16 00:03:22.387 -04:00] [INFO] [client.go:567] ["Backup Ranges"] [take=67ns]

What is changed and how it works?

Fix the code of printing the log. After fixed, it shows the correct time for backup ranges.

[2022/06/16 00:17:02.284 -04:00] [INFO] [client.go:538] ["Backup Ranges"] [take=595.572234ms]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ixuh12 @ti-srebot
cherry pick pingcap#35552 to release-6.0
7fccef5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2022

/run-all-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 23, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2022
Merged
12 tasks
@ti-srebot ti-srebot added component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.0-cherry-pick labels Jun 23, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
@ti-srebot ti-srebot requested review from 3pointer and joccau June 23, 2022 15:13
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2022

@joccau you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7fccef58b7104fbf86473a05c72a6dd9a331ff0d

@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

closed for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

@joccau joccau Awaiting requested review from joccau

Assignees

@joccau joccau

Labels

component/br This issue is related to BR of TiDB. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/6.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @sre-bot @xhebox @joccau @ixuh12