Skip to content

session,sessionctx: enable tidb_enable_paging by default#35275

Merged
ti-chi-bot merged 16 commits intopingcap:masterfrom
tiancaiamao:enable-paging
Jun 23, 2022
Merged

session,sessionctx: enable tidb_enable_paging by default#35275
ti-chi-bot merged 16 commits intopingcap:masterfrom
tiancaiamao:enable-paging

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jun 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35273

Problem Summary:

Please review #35244 first, this is based on that PR.

What is changed and how it works?

Set the default tidb_enable_paging value to true.
For the newly bootstraped cluster, the global variable tidb_enable_paging is set.
For the old cluster, the default value is not changed.

The would make us cover the bugs as soon as possible before the next release.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

For a newly bootstraped cluster, the default value of `tidb_enable_paging` is true. The coprocessor paging protocol is enabled by default. For existing cluster, the default value is still false unless the user set it explicitly.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 9, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review June 9, 2022 13:21
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 9, 2022
@tiancaiamao tiancaiamao requested a review from a team as a code owner June 9, 2022 13:21
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2022
@tiancaiamao tiancaiamao requested review from XuHuaiyu and wshwsh12 June 9, 2022 13:21
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2e4ebf4d5586ece5245b6942669db5ea8e78781a

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jun 10, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jun 22, 2022

ref #35633

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2022

@tiancaiamao: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2e4ebf4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jun 22, 2022

/run-realtikv-test

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jun 23, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 193f04d into pingcap:master Jun 23, 2022
@tiancaiamao tiancaiamao deleted the enable-paging branch June 23, 2022 00:35
@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 10, total 11 34 min New failing
idc-jenkins-ci-tidb/tics-test 🟥 failed 1, success 0, total 1 3 min 55 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 45 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 40 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao mentioned this pull request Jun 23, 2022
Closed
@Yui-Song Yui-Song mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable coprocessor paging by default

5 participants

@tiancaiamao @ti-chi-bot @sre-bot @XuHuaiyu @wshwsh12