Skip to content

tools/check: 'ut' now remove support for the old test cases#34800

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
tiancaiamao:ut-old
May 19, 2022
Merged

tools/check: 'ut' now remove support for the old test cases#34800
ti-chi-bot merged 2 commits intopingcap:masterfrom
tiancaiamao:ut-old

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented May 19, 2022

What problem does this PR solve?

Issue Number: close #30822

Problem Summary:

Since the test case migration is done #26022, we can now remove the support for the old test case.

What is changed and how it works?

Address comment here #30822 (comment)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2022
tisonkun
tisonkun approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although, I'm unsure whether this pr completely "closes" #30822.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a32f425b137048d3355689aecf3740173e154e67

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@hawkingrei
Copy link
Member

hawkingrei commented May 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 11025b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@tisonkun
Copy link
Contributor

tisonkun commented May 19, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 098dee6 into pingcap:master May 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 33, total 34 30 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 7 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 36 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make CI great again!

5 participants

@tiancaiamao @ti-chi-bot @sre-bot @hawkingrei @tisonkun