Skip to content

*: move config file option committer-concurrency to sysvar#34368

Merged
ti-chi-bot merged 18 commits intopingcap:masterfrom
espresso98:tidb-committer-concurrency
May 13, 2022
Merged

*: move config file option committer-concurrency to sysvar#34368
ti-chi-bot merged 18 commits intopingcap:masterfrom
espresso98:tidb-committer-concurrency

Conversation

@espresso98
Copy link
Collaborator

@espresso98 espresso98 commented May 4, 2022

What problem does this PR solve?

Issue Number: ref #33769

Problem Summary:

The option committer-concurrency has historically been a config option. Based on requirements from cloud & PM it should instead be a GLOBAL sysvar.

What is changed and how it works?

This PR converts the option committer-concurrency to a global (cluster-wide) sysvar tidb-committer-concurrency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The TiDB configuration file option `committer-concurrency` has been replaced by the global system variable `tidb-committer-concurrency`. This change makes it easier to modify this setting on a cluster wide basis.

@espresso98 espresso98 requested a review from a team as a code owner May 4, 2022 21:39
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a4da22c9db40d4f6befef04ca6d54ec483e2e0a6

@espresso98
Copy link
Collaborator Author

espresso98 commented May 5, 2022

Please review @morgo

morgo
morgo approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sysvar/config changes LGTM, but I'll find a tikv reviewer so we can make sure the change is working correctly.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
morgo
morgo reviewed May 5, 2022
View reviewed changes
morgo
morgo reviewed May 5, 2022
View reviewed changes
@morgo morgo self-requested a review May 5, 2022 17:21
@morgo
Copy link
Contributor

morgo commented May 6, 2022

/run-check_dev_2

@cfzjywxk cfzjywxk requested review from MyonKeminta, sticnarf and you06 May 6, 2022 01:57
cfzjywxk
cfzjywxk approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2022
you06
you06 reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this PR LGTM

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2022
you06
you06 reviewed May 7, 2022
View reviewed changes
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why remove go.sum?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022
@morgo morgo mentioned this pull request May 11, 2022
Open
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 11, 2022
you06
you06 reviewed May 12, 2022
View reviewed changes
@morgo
Copy link
Contributor

morgo commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 39905d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2022
@morgo
Copy link
Contributor

morgo commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a4da22c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot merged commit 0017963 into pingcap:master May 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 8 min 22 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 19 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 59 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@zimulala zimulala mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@you06 you06 you06 approved these changes

@morgo morgo Awaiting requested review from morgo

@sticnarf sticnarf Awaiting requested review from sticnarf

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@espresso98 @ti-chi-bot @sre-bot @morgo @cfzjywxk @you06