*: move config file option query-log-max-len to sysvar#34305
Merged
ti-chi-bot merged 19 commits intopingcap:masterfrom May 3, 2022
Merged
*: move config file option query-log-max-len to sysvar#34305ti-chi-bot merged 19 commits intopingcap:masterfrom
ti-chi-bot merged 19 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9c92c0ae1e293cb192675927d868f0cec500f28f |
Collaborator
Author
|
Please review @morgo |
7814c31 to
4a2586e
Compare
Contributor
|
LGTM, but please resolve conflicts :-) |
morgo
approved these changes
May 2, 2022
dveeden
approved these changes
May 3, 2022
Contributor
dveeden
left a comment
There was a problem hiding this comment.
sql> SET GLOBAL tidb_query_log_max_len=5;
Query OK, 0 rows affected (0.0047 sec)
sql> select sleep(id) from t1;
+-----------+
| sleep(id) |
+-----------+
| 0 |
+-----------+
1 row in set (5.0028 sec)
# Time: 2022-05-03T08:27:00.93426371+02:00
# Txn_start_ts: 432946339101278208
# User@Host: root[root] @ ::1 [::1]
# Conn_ID: 403
# Query_time: 5.002372906
# Parse_time: 0.000205323
# Compile_time: 0.000498304
# Rewrite_time: 0.000165694
# Optimize_time: 0.000127934
# Wait_TS: 0.000028787
# Cop_time: 0.000409313 Request_count: 1
# DB: test
# Is_internal: false
# Digest: 850922af8bcba539198bb9559d6e317af6768dbd53539fee0225f44600f68688
# Stats: t1:pseudo
# Num_cop_tasks: 1
# Cop_proc_avg: 0 Cop_proc_addr: store1
# Cop_wait_avg: 0 Cop_wait_addr: store1
# Mem_max: 539
# Prepared: false
# Plan_from_cache: false
# Plan_from_binding: false
# Has_more_results: false
# KV_total: 0
# PD_total: 0.000004407
# Backoff_total: 0
# Write_sql_response_total: 0.00000353
# Result_rows: 1
# Succ: true
# IsExplicitTxn: false
# Plan: tidb_decode_plan('hAPwkDAJM18zCTAJMQlzbGVlcChjYXN0KHRlc3QudDEuaWQsIGRvdWJsZSBCSU5BUlkpKS0+Q29sdW1uIzIJMQl0aW1lOjVzLCBsb29wczoyLCBDb25jdXJyZW5jeTpPRkYJMzgwIEJ5dGVzCU4vQQoxCTMxXzUJMAkxCWRhdGE6VGFibGVGdWxsU2Nhbl80CTEJdGkBUhgxOC4xwrVzHVhwY29wX3Rhc2s6IHtudW06IDEsIG1heDogMjc5LjkFK0Rwcm9jX2tleXM6IDAsIHJwY18RKQEMBaoUIDE5OC40BS54Y29wcl9jYWNoZV9oaXRfcmF0aW86IDAuMDB9CTE1OR20JDIJNDNfNAkxXzABnwGxiDp0MSwga2VlcCBvcmRlcjpmYWxzZSwgc3RhdHM6cHNldWRvASsIaWt2CbMAewV9EDE1My42BXwAbCUtKDB9CU4vQQlOL0EK')
# Plan_digest: e81eea3563158d75f62a9ce11cffdbdb995e1c92323448dbebc16f8f154e2c46
"selec"(len:24);
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 0e6491a |
Member
|
/run-mysql-test |
Contributor
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
16 tasks
14 tasks
bb7133
reviewed
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #33769
Problem Summary:
The option
query-log-max-lenhas historically been a config option andtidb-query-log-max-lenhas existed as a session variable. Based on requirements from cloud & PM it should instead be aGLOBALsysvar.What is changed and how it works?
This PR converts the option
query-log-max-lento a global (cluster-wide) sysvartidb-query-log-max-len, and removes the config option and the session sysvar.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.