planner: demo of new cost interface(refactor)#33563
planner: demo of new cost interface(refactor)#33563qw4990 wants to merge 189 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
planner/core/find_best_task.go
Outdated
| } | ||
|
|
||
| //// TODO: introduce a new variable as a switch to control this | ||
| //if curTask.plan().CalPlanCost(property.RootTaskType) < bestTask.plan().CalPlanCost(property.RootTaskType) || (bestTask.invalid() && !curTask.invalid()) { |
There was a problem hiding this comment.
It's possible that the task is not root type right?
Such as the case that double read case
There was a problem hiding this comment.
You are right. Now I introduce a new function getTaskType(task) type to get their types.
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
What problem does this PR solve?
Issue Number: close #33945
Problem Summary:
What is changed and how it works?
Please see #33945 for more details.
Check List
Tests
Side effects
Documentation
Release note