Skip to content

ddl: migrate test-infra to testify for column_type_change_type#32694

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
hawkingrei:ctc_test
Mar 2, 2022
Merged

ddl: migrate test-infra to testify for column_type_change_type#32694
ti-chi-bot merged 9 commits intopingcap:masterfrom
hawkingrei:ctc_test

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 1, 2022

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #28632

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hawkingrei
ddl: migrate test-infra to testify for column_type_change_type
86f2a91 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2022
@hawkingrei
ddl: migrate test-infra to testify for column_type_change_type
f96a138 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
ddl: migrate test-infra to testify for column_type_change_type
9c5b4b8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
ddl: migrate test-infra to testify for column_type_change_type
6d1780a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
admin: improve CancelJobs
6ec7651 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ec2eb59baf3309134ca14bb4100f0f4a00c97343

@hawkingrei hawkingrei requested a review from morgo March 1, 2022 15:49
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@xiongjiwei
Copy link
Contributor

xiongjiwei commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6ec7651

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@hawkingrei
Copy link
Member Author

hawkingrei commented Mar 2, 2022

/run-mysql-test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

hawkingrei commented Mar 2, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 52da782 into pingcap:master Mar 2, 2022
@hawkingrei hawkingrei deleted the ctc_test branch March 2, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@morgo morgo Awaiting requested review from morgo

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for ddl/column_type_change_test.go

5 participants

@hawkingrei @ti-chi-bot @sre-bot @xiongjiwei @tisonkun