Skip to content

*: replace compareDatum by compare and fix wrong optimize order by (#30273)#32321

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.2from
ti-srebot:release-5.2-94be83bfa641
Closed

*: replace compareDatum by compare and fix wrong optimize order by (#30273)#32321
ti-srebot wants to merge 1 commit intopingcap:release-5.2from
ti-srebot:release-5.2-94be83bfa641

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 14, 2022 •
edited
Loading

cherry-pick #30273 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32321

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32321:release-5.2-94be83bfa641

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #30271. Related to #29867.

Problem Summary:

  1. replace compareDatum by compare
  2. isSameValue may use wrong collation

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix a bug when reducing order by clause for the index which leads to the wrong result.

@wjhuang2016 @ti-srebot
cherry pick pingcap#30273 to release-5.2
8c9f4b4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 14, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Feb 14, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 14, 2022
@ti-srebot ti-srebot mentioned this pull request Feb 14, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.2-cherry-pick labels Feb 14, 2022
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Feb 14, 2022

@wjhuang2016 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@winoros
Copy link
Member

winoros commented Apr 19, 2022

This one is duplicated. See #30551

@winoros winoros closed this Apr 19, 2022
@winoros winoros deleted the release-5.2-94be83bfa641 branch April 19, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees

@wjhuang2016 wjhuang2016

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.2-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @winoros @VelocityLight @wjhuang2016