Skip to content

planner/core: migrate test-infra to testify for rule_ tests#32179

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
tisonkun:issue-28397
Feb 9, 2022
Merged

planner/core: migrate test-infra to testify for rule_ tests#32179
ti-chi-bot merged 1 commit intopingcap:masterfrom
tisonkun:issue-28397

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Feb 9, 2022

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #28396 close #28397 close #28398

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 9, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 9, 2022

/cc @hawkingrei @rebelice

cc @johnhaxx7

@sre-bot
Copy link
Contributor

sre-bot commented Feb 9, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9a5745b89dd2c2bc59cb4c4a09e7197ca841702d

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 9, 2022

/cc @hawkingrei @disksing

@ti-chi-bot ti-chi-bot requested a review from disksing February 9, 2022 04:28
@hawkingrei
Copy link
Member

hawkingrei commented Feb 9, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2022
@rebelice
Copy link
Contributor

rebelice commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8561880a6332170f059dbff8834026ef0b9cab7e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun @hawkingrei
planner/core: migrate test-infra to testify for rule_ tests
9a5745b 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Feb 9, 2022

/run-all-tests

@tisonkun
Copy link
Contributor Author

tisonkun commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9a5745b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot ti-chi-bot merged commit 297455d into pingcap:master Feb 9, 2022
@tisonkun tisonkun deleted the issue-28397 branch April 13, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@rebelice rebelice rebelice approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

5 participants

@tisonkun @ti-chi-bot @sre-bot @hawkingrei @rebelice