Skip to content

planner: migrate test-infra to testify for memtable_predicate_extractor_test.go#31473

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:migrate_memtable_predicate_extractor
Jan 8, 2022
Merged

planner: migrate test-infra to testify for memtable_predicate_extractor_test.go#31473
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:migrate_memtable_predicate_extractor

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 8, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #28403

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 8, 2022
@hawkingrei hawkingrei changed the title planner: migrate test-infra to testify for planner/core/memtable_pred… planner: migrate test-infra to testify for memtable_predicate_extractor_test.go Jan 8, 2022
@hawkingrei
planner: migrate test-infra to testify for memtable_predicate_extract…
93942f2 
…or_test.go

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the migrate_memtable_predicate_extractor branch from 490f49b to 93942f2 Compare January 8, 2022 03:02
@hawkingrei hawkingrei requested a review from tisonkun January 8, 2022 03:03
@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 8, 2022

/cc @tisonkun @tangenta

@ti-chi-bot ti-chi-bot requested a review from tangenta January 8, 2022 03:03
@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 8, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/75b5f48c78300e027f7062a724be5d8ead36c27d

@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 8, 2022

/run-check_dev_2

tisonkun
tisonkun approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @hawkingrei! LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 8, 2022
@rebelice
Copy link
Contributor

rebelice commented Jan 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 93942f2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 8, 2022

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 8, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit b9a0eb6 into pingcap:master Jan 8, 2022
@hawkingrei hawkingrei deleted the migrate_memtable_predicate_extractor branch January 8, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

@rebelice rebelice rebelice approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for planner/core/memtable_predicate_extractor_test.go

5 participants

@hawkingrei @ti-chi-bot @sre-bot @rebelice @tisonkun