ddl: support batch create table (#28763)#31234
ddl: support batch create table (#28763)#31234ti-srebot wants to merge 1 commit intopingcap:release-5.4from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@xhebox you're already a collaborator in bot's repo. |
|
closed, since nobody needs it. |
cherry-pick #28763 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/31234After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: refer #30272
Problem Summary: add an internal batch create table api for br, all happens in one schema version.
Some notes on the behavior:
querysince it is not from parser. One must setctx.Value(sessionctx.QueryString)manually for displayingadmin show ddl queries.admin show ddl jobscan not show multiple ids intableIDcolumn, but will show comma separated list of table names intableNamecolumn.What is changed and how it works?
What's Changed:
CreateTablesWithInfo, the new batch api.CreateTableWithInfoandCreateTablesWithInfoare extracted.onCreateTableandonCreateTablesare extracted.db_test.goandtable_test.go.Affected []HistoryInfoAffectedinbinlog.HistoryInfofor display multiple table names.Check List
Tests
Side effects
Documentation
Release note