Skip to content

planner: fix AccessPath.TableFilters got modified unexpectedly (#30966)#30976

Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-e24493f411e6
Closed

planner: fix AccessPath.TableFilters got modified unexpectedly (#30966)#30976
ti-srebot wants to merge 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-e24493f411e6

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 23, 2021 •
edited
Loading

cherry-pick #30966 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30976

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30976:release-5.0-e24493f411e6

What problem does this PR solve?

Issue Number: close #30965

Problem Summary:

SplitSelCondsWithVirtualColumn will modify the slice argument.

We pass AccessPath.TableFilters to SplitSelCondsWithVirtualColumn. This makes the following process of physical optimization generate wrong query plans.

What is changed and how it works?

SplitSelCondsWithVirtualColumn no longer modifies the argument slice. Now it returns two new slices.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@time-and-fate @ti-srebot
cherry pick pingcap#30966 to release-5.0
76fd589 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 23, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 23, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 23, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Dec 23, 2021
@ti-srebot ti-srebot added this to the v5.0.6 milestone Dec 23, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 23, 2021

@time-and-fate you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2021
@VelocityLight
Copy link

VelocityLight commented Sep 21, 2022

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@time-and-fate time-and-fate

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.6

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @VelocityLight @winoros @Reminiscent @time-and-fate