Skip to content

dumpling: fix dump failed when sequence exists (#30164)#30877

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.3from
ti-srebot:release-5.3-9d307b00ae86
Feb 18, 2022
Merged

dumpling: fix dump failed when sequence exists (#30164)#30877
ti-chi-bot merged 4 commits intopingcap:release-5.3from
ti-srebot:release-5.3-9d307b00ae86

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 20, 2021 •
edited
Loading

cherry-pick #30164 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30877

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30877:release-5.3-9d307b00ae86

What problem does this PR solve?

Issue Number: close #30149
Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@sylzd @ti-srebot
cherry pick pingcap#30164 to release-5.3
60db6c5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu
  • sylzd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 20, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 20, 2021
Merged
12 tasks
@ti-srebot ti-srebot added component/dumpling This is related to Dumpling of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick type/bugfix This PR fixes a bug. labels Dec 20, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 20, 2021

@sylzd you're already a collaborator in bot's repo.

kennytm
kennytm reviewed Dec 20, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2021
@sylzd
Copy link
Contributor

sylzd commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021

@sylzd: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor

lichunzhu commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b3666b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@lichunzhu
Copy link
Contributor

lichunzhu commented Feb 7, 2022

/assign nongfushanquan

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

@lichunzhu: GitHub didn't allow me to assign the following users: nongfushanquan.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign nongfushanquan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 15, 2022
@purelind
Copy link
Contributor

purelind commented Feb 17, 2022

/run-mysql-test

2 similar comments
@lichunzhu
Copy link
Contributor

lichunzhu commented Feb 18, 2022

/run-mysql-test

@lichunzhu
Copy link
Contributor

lichunzhu commented Feb 18, 2022

/run-mysql-test

@lichunzhu lichunzhu closed this Feb 18, 2022
@lichunzhu lichunzhu reopened this Feb 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8d5832a into pingcap:release-5.3 Feb 18, 2022
@lichunzhu lichunzhu deleted the release-5.3-9d307b00ae86 branch February 18, 2022 06:45
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

@AilinKid AilinKid Awaiting requested review from AilinKid

@tangenta tangenta Awaiting requested review from tangenta

@zhouqiang-cl zhouqiang-cl Awaiting requested review from zhouqiang-cl

+2 more reviewers

@sylzd sylzd sylzd approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sylzd sylzd

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.3-cherry-pick

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @sylzd @lichunzhu @purelind @kennytm @zhouqiang-cl