Skip to content

executor: buildWindow cannot call typeInfer twice (#30773)#30863

Merged
ti-chi-bot merged 10 commits intopingcap:release-5.1from
ti-srebot:release-5.1-e3c56b75eaeb
Jun 22, 2022
Merged

executor: buildWindow cannot call typeInfer twice (#30773)#30863
ti-chi-bot merged 10 commits intopingcap:release-5.1from
ti-srebot:release-5.1-e3c56b75eaeb

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 20, 2021 •
edited
Loading

cherry-pick #30773 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30863

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30863:release-5.1-e3c56b75eaeb

What problem does this PR solve?

Issue Number: close #30402

Problem Summary: build window desc call TypeInfer twice, which change the return type incorrectly. For example, avg() in window func, a int type is first inferred to decimal(15,4), then inferred to decimal(19,8), which breaks compatibility with mysql.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fzhedu @ti-srebot
cherry pick pingcap#30773 to release-5.1
6e0839e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 20, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 20, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Dec 20, 2021
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 20, 2021

@fzhedu you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2022

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 21, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/rebuild

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/587b9ee7dea3df6163fd6e599e74cfdf494a18f7

fzhedu
fzhedu approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2022
windtalker
windtalker approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@windtalker
Copy link
Contributor

windtalker commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 587b9ee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit acae58f into pingcap:release-5.1 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

+1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fzhedu fzhedu

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.1-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @fzhedu @sre-bot @windtalker @VelocityLight