executor: add an unit test case for unreasonable invoking Close (#30696)#30769
Merged
ti-chi-bot merged 7 commits intopingcap:release-5.1from Sep 20, 2022
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
Author
|
/run-all-tests |
1 task
Contributor
Author
|
@XuHuaiyu you're already a collaborator in bot's repo. |
wshwsh12
approved these changes
Jan 11, 2022
guo-shaoge
approved these changes
Sep 19, 2022
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 22061c6 |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: e0b6270 |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: a30d028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #30696 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30769After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Inspired by #27125, #30587, and #30289, there is a common problem that the
Closefunction may be invoked but theOpenfunction is not invoked or returned with an error. In this senario, some member attributes are not initialized and the nil pointer panic triggered when invokingClose.I add a unit test in this commit to test invoking the
Closefunction directly without invoking theOpenfunction before.With this test, 3 more similar bugs are also found in
MergeJoinExec,CTEExec,IndexReader.What is changed and how it works?
Check List
Tests
Side effects
N/A
Documentation
N/A
Release note