Skip to content

ddl: handle the error from addBatchDDLJobs() correctly (#30401)#30761

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-464db6b5370b
Closed

ddl: handle the error from addBatchDDLJobs() correctly (#30401)#30761
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-464db6b5370b

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 16, 2021 •
edited
Loading

cherry-pick #30401 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30761

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30761:release-5.0-464db6b5370b

What problem does this PR solve?

Issue Number: close #30400

What is changed and how it works?

Handle the error from addBatchDDLJob() correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue that DDL progress can be blocked due to high concurrency.

@ti-srebot
cherry pick pingcap#30401 to release-5.0
c0f9066 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 16, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 16, 2021
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Dec 16, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 16, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 16, 2021

@tangenta you're already a collaborator in bot's repo.

@tangenta
Copy link
Contributor

tangenta commented Dec 16, 2021

Close, as the bug is rarely encountered. There is no need to cherry-pick.

@tangenta tangenta closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid Awaiting requested review from AilinKid

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@tangenta tangenta

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @ti-chi-bot @tangenta