expression: fix tidb can't alter table from other-type with null value to timestamp with NOT NULL attribute (#29664)#30739
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@AilinKid you're already a collaborator in bot's repo. |
|
I think it's not critical for insert problem, just refuse to insert null value. |
cherry-pick #29664 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30739After apply modifications, you can push your change to this PR via:
Signed-off-by: ailinkid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #29328
What is changed and how it works?
After testing from mysql8, we found that there is a special case for timestamp to handle with null values.
It will convert null value to current timestamp although the target timestamp type has a NOT NULL value.
check the origin issue comments for more details
Check List
Tests
Release note