Skip to content

server: support decoding prepared string args to character_set_client (#30723)#30735

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-04a9618f5ccc
Closed

server: support decoding prepared string args to character_set_client (#30723)#30735
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-04a9618f5ccc

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 15, 2021 •
edited
Loading

cherry-pick #30723 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30735

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30735:release-5.3-04a9618f5ccc

What problem does this PR solve?

Fix #30722.

Problem Summary:

Previously, the command ComStmtExecute is not aware of @@character_set_client.

What is changed and how it works?

This PR support

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-srebot
cherry pick pingcap#30723 to release-5.3
648e3da 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 15, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 15, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 15, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 15, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 15, 2021

@tangenta you're already a collaborator in bot's repo.

@tangenta
Copy link
Contributor

tangenta commented Dec 15, 2021

/run-build-arm64 comment=true

1 similar comment
@purelind
Copy link
Contributor

purelind commented Dec 15, 2021

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Dec 15, 2021

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/648e3da809a65af58c0d06bf1851386e0c1c70b6/centos7/tidb-linux-arm64.tar.gz

@tiancaiamao tiancaiamao changed the base branch from release-5.3 to release-5.3-20220107 January 10, 2022 03:33
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2022
@tiancaiamao tiancaiamao changed the base branch from release-5.3-20220107 to release-5.3 January 10, 2022 03:34
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 10, 2022
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 15, 2022

/run-mysql-test
@tangenta please remember to merge this. A new version is about to release. Thanks!

@tangenta
Copy link
Contributor

tangenta commented Feb 16, 2022

The feature GBK charset is not fully supported in release 5.3.

@tangenta tangenta closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@tangenta tangenta

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @tangenta @purelind @sre-bot @guo-shaoge