Skip to content

planner, util/ranger: fix wrong optimize order by (#30273)#30552

Merged
ti-chi-bot merged 3 commits intopingcap:release-5.3from
xuyifangreeneyes:cherrypick-30273-53
Feb 22, 2022
Merged

planner, util/ranger: fix wrong optimize order by (#30273)#30552
ti-chi-bot merged 3 commits intopingcap:release-5.3from
xuyifangreeneyes:cherrypick-30273-53

Conversation

@xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Dec 8, 2021

cherry-pick #30273 to release-5.3

What problem does this PR solve?

Issue Number: close #30271

Problem Summary:
isSameValue may use wrong collation.

What is changed and how it works?

Use CollationBin for comparing datums in isSameValue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix a bug when reducing order by clause for the index which leads to the wrong result.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Dec 8, 2021

/cc @wjhuang2016 @xiongjiwei

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 21, 2022

/cc @winoros

@ti-chi-bot ti-chi-bot requested a review from winoros February 21, 2022 12:43
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2022
@winoros
Copy link
Member

winoros commented Feb 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1935627

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 21, 2022
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 22, 2022

/run-mysql-test

2 similar comments
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Feb 22, 2022

/run-mysql-test

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 22, 2022

/run-mysql-test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 22, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit b04545c into pingcap:release-5.3 Feb 22, 2022
@xuyifangreeneyes xuyifangreeneyes deleted the cherrypick-30273-53 branch February 22, 2022 07:04
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
@winoros winoros mentioned this pull request Apr 19, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@winoros winoros Awaiting requested review from winoros

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

8 participants

@xuyifangreeneyes @ti-chi-bot @winoros @guo-shaoge @xiongjiwei @time-and-fate @VelocityLight @purelind