Skip to content

server: Fix unstable tests with FakeAuthSwitch (#30287)#30478

Closed
ti-srebot wants to merge 3 commits intopingcap:release-5.3from
ti-srebot:release-5.3-d7c2333e6328
Closed

server: Fix unstable tests with FakeAuthSwitch (#30287)#30478
ti-srebot wants to merge 3 commits intopingcap:release-5.3from
ti-srebot:release-5.3-d7c2333e6328

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 7, 2021 •
edited
Loading

cherry-pick #30287 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30478

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30478:release-5.3-d7c2333e6328

What problem does this PR solve?

Issue Number: close #30266

Problem Summary:

Looks like both tests (TestAuthPlugin2 and TestHandleAuthPlugin have t.Parallel() and enable/disable the FakeAuthSwitch failpoint. The result is that the failpoint is not enabled when the test expect it to be enabled.

What is changed and how it works?

This now uses a context to make this stable.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Note that I'm relatively new to the use of failpoints and there isn't much documentation on how to use this with contexts, so please make sure this is the correct way of using this

@dveeden @ti-srebot
cherry pick pingcap#30287 to release-5.3
9354e70 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 7, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 7, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 7, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 7, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 7, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 7, 2021

@dveeden you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2021
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 15, 2022

@dveeden Maybe we can continue to merge this pr. A new version is about to release in a few days. Thanks!
/run-check_dev
/run-mysql-test

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 15, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2022
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 21, 2022

/run-mysql-test

@VelocityLight
Copy link

VelocityLight commented Sep 16, 2022

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@djshow832 djshow832 Awaiting requested review from djshow832

@morgo morgo Awaiting requested review from morgo

Assignees

@dveeden dveeden

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @guo-shaoge @VelocityLight @dveeden