Skip to content

executor: avoid sum from avg overflow (#30010)#30383

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-9aa756336e7b
Closed

executor: avoid sum from avg overflow (#30010)#30383
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-9aa756336e7b

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 3, 2021 •
edited
Loading

cherry-pick #30010 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30383

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30383:release-4.0-9aa756336e7b

What problem does this PR solve?

Issue Number: close #29952

Problem Summary:

  1. the sum from avg may overflow, we should infer the type as the normal sum.
  2. the previous PR expression, planner: fix decimal results for aggregate functions #20017 is a hack to fix the issue , we should let the final agg output the target return type which is inferred in TypeInfe() for Agg.
  3. typeInfer4xxx should valid the precision and scale of decimal type.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fzhedu @ti-srebot
cherry pick pingcap#30010 to release-4.0
b9d8f15 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 3, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/4.0-cherry-pick labels Dec 3, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 3, 2021

@fzhedu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

close for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@windtalker windtalker Awaiting requested review from windtalker

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@fzhedu fzhedu

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/4.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @xhebox @fzhedu