Skip to content

executor: avoid sum from avg overflow (#30010)#30379

Merged
ti-chi-bot merged 8 commits intopingcap:release-5.3from
ti-srebot:release-5.3-9aa756336e7b
Sep 19, 2022
Merged

executor: avoid sum from avg overflow (#30010)#30379
ti-chi-bot merged 8 commits intopingcap:release-5.3from
ti-srebot:release-5.3-9aa756336e7b

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 3, 2021 •
edited
Loading

cherry-pick #30010 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30379

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30379:release-5.3-9aa756336e7b

What problem does this PR solve?

Issue Number: close #29952

Problem Summary:

  1. the sum from avg may overflow, we should infer the type as the normal sum.
  2. the previous PR expression, planner: fix decimal results for aggregate functions #20017 is a hack to fix the issue , we should let the final agg output the target return type which is inferred in TypeInfe() for Agg.
  3. typeInfer4xxx should valid the precision and scale of decimal type.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fzhedu @ti-srebot
cherry pick pingcap#30010 to release-5.3
cc4b552 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 3, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 3, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 3, 2021

@fzhedu you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 15, 2022

@fzhedu Maybe it's time to continue to merge this pr. A new version is about to release. Thanks!
/run-check_dev
/run-mysql-test

@guo-shaoge guo-shaoge mentioned this pull request Feb 23, 2022
Merged
12 tasks
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 16, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2022
@LittleFall LittleFall added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@LittleFall LittleFall added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 19, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Sep 19, 2022
@LittleFall LittleFall force-pushed the release-5.3-9aa756336e7b branch from 6d5d66c to d075de2 Compare September 19, 2022 08:45
windtalker
windtalker approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2022
@windtalker
Copy link
Contributor

windtalker commented Sep 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 167effe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@ti-chi-bot ti-chi-bot merged commit 31042ee into pingcap:release-5.3 Sep 19, 2022
@LittleFall LittleFall deleted the release-5.3-9aa756336e7b branch September 19, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

+1 more reviewer

@LittleFall LittleFall LittleFall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fzhedu fzhedu

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @guo-shaoge @windtalker @LittleFall @fzhedu @VelocityLight