Skip to content

*: add warn log for stale read (#30340)#30351

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-6475e8949cf4
Closed

*: add warn log for stale read (#30340)#30351
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-6475e8949cf4

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 2, 2021 •
edited
Loading

cherry-pick #30340 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30351

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30351:release-5.3-6475e8949cf4

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

add warn log for stale read to help debug.

Release note

None

@Yisaer @ti-srebot
cherry pick pingcap#30340 to release-5.3
affaa34 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 2, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 2, 2021
Merged
@ti-srebot ti-srebot requested review from JmPotato and xhebox December 2, 2021 10:01
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Dec 2, 2021

@Yisaer you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2021
@xhebox
Copy link
Contributor

xhebox commented Jan 26, 2022

@Yisaer need cherry-pick approval, maybe contact someone to help?

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 15, 2022

@Yisaer please remember to merge this pr. Thnaks!

@zimulala
Copy link
Contributor

zimulala commented Apr 9, 2025

The v5.3.x version is quite old, and cherry-picking PRs to this version has been suspended. We’ll close this PR for now. Please feel free to reopen it if needed.

@zimulala zimulala closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

@Yisaer Yisaer

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @xhebox @guo-shaoge @zimulala @JmPotato @Yisaer