Skip to content

planner: rebuild range when the range is empty(#30003)#30270

Merged
zhouqiang-cl merged 2 commits intopingcap:release-5.3-20211117from
qw4990:release-5.3-20211117-fixup
Nov 30, 2021
Merged

planner: rebuild range when the range is empty(#30003)#30270
zhouqiang-cl merged 2 commits intopingcap:release-5.3-20211117from
qw4990:release-5.3-20211117-fixup

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 30, 2021

cherry-pick #30003 to release-5.3-20211117
You can switch your code base to this Pull Request by using git-extras:

What problem does this PR solve?

Issue Number: close #29993
close #30100

Problem Summary:

  1. Do not check whether the range is empty.
  2. Do not generate tableDual plan.

What is changed and how it works?

  1. Check the length of the range.
  2. Generate the tableDual and uncache the plan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Nov 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2021

@qw4990: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2021
@qw4990 qw4990 changed the title cherry pick planner: rebuild range when the range is empty(#30003) Nov 30, 2021
@qw4990 qw4990 requested a review from Reminiscent November 30, 2021 08:09
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@qw4990 qw4990 requested a review from rebelice November 30, 2021 08:11
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2021
@Reminiscent
Copy link
Contributor

Reminiscent commented Nov 30, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f8c9e71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@zhouqiang-cl zhouqiang-cl merged commit d096728 into pingcap:release-5.3-20211117 Nov 30, 2021
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

7 participants

@qw4990 @ti-chi-bot @sre-bot @Reminiscent @rebelice @purelind @zhouqiang-cl