Skip to content

server: Combined fix for authentication issues (#29738)#30233

Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.3from
ti-srebot:release-5.3-6756bd2ea824
Closed

server: Combined fix for authentication issues (#29738)#30233
ti-srebot wants to merge 2 commits intopingcap:release-5.3from
ti-srebot:release-5.3-6756bd2ea824

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 29, 2021 •
edited
Loading

cherry-pick #29738 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30233

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30233:release-5.3-6756bd2ea824

What problem does this PR solve?

Issue Number:

Problem Summary:

Combined fix for multiple authentication issues

Contains fixes from:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

- Compatibility with MySQL 5.1 clients has been improved

@dveeden @ti-srebot
cherry pick pingcap#29738 to release-5.3
a74b766 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 29, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick labels Nov 29, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

@dveeden you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2021
@dveeden
Copy link
Contributor

dveeden commented Nov 29, 2021

From https://github.com/dveeden/tidb_client_test:

TiDB Client Test
Connected to:
	Release Version: v5.3.0-3-g6a0263a39
	Edition: Community
	Git Commit Hash: 6a0263a39545da3944627c747bfcada74d3324e7
	Git Branch: release-5.3-6756bd2ea824
	UTC Build Time: 2021-11-29 14:53:26
	GoVersion: go1.16.8
	Race Enabled: false
	TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
	Check Table Before Drop: false
Clients:
	/home/dvaneeden/opt/mysql/5.1.73/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.31/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.36/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.22/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.25/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.26/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.27/bin/mysql
-----------------------------------------------
Testing with mysql_native_password as default authentication plugin
Testing /home/dvaneeden/opt/mysql/5.1.73/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/5.7.31/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/5.7.36/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.22/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.25/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.26/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.27/bin/mysql: success=8, failures=0
Testing with caching_sha2_password as default authentication plugin
Testing /home/dvaneeden/opt/mysql/5.1.73/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/5.7.31/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/5.7.36/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.22/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.25/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.26/bin/mysql: success=8, failures=0
Testing /home/dvaneeden/opt/mysql/8.0.27/bin/mysql: success=8, failures=0

@dveeden
Copy link
Contributor

dveeden commented Nov 29, 2021

#30047 should probably be merged first

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2021
@dveeden dveeden force-pushed the release-5.3-6756bd2ea824 branch 4 times, most recently from 916057a to 4cfc62f Compare November 29, 2021 16:14
@dveeden dveeden force-pushed the release-5.3-6756bd2ea824 branch from 4cfc62f to 766c947 Compare November 29, 2021 16:53
@dveeden
Copy link
Contributor

dveeden commented Nov 29, 2021

/run-check_dev

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2022
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Mar 2, 2022

Looks like #30450 already fixed.

@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Nov 2, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Nov 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 27, 2023
@dveeden dveeden closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dveeden dveeden dveeden approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

@dveeden dveeden

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @dveeden @guo-shaoge @VelocityLight @zhouqiang-cl