Skip to content

types: fix wrong str_to_date() microseconds with leading zeros are not converted correctly (#30122)#30221

Merged
ti-chi-bot merged 3 commits intopingcap:release-5.1from
ti-srebot:release-5.1-352811dfc4ee
Feb 9, 2022
Merged

types: fix wrong str_to_date() microseconds with leading zeros are not converted correctly (#30122)#30221
ti-chi-bot merged 3 commits intopingcap:release-5.1from
ti-srebot:release-5.1-352811dfc4ee

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 29, 2021 •
edited
Loading

cherry-pick #30122 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30221

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30221:release-5.1-352811dfc4ee

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #30078

str_date doesn't parse microseconds correctly.

What is changed and how it works?

It's very easy. Not sure why it was wrong before.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016 @ti-srebot
cherry pick pingcap#30122 to release-5.1
faca3ea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 29, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.1-cherry-pick labels Nov 29, 2021
@ti-srebot ti-srebot requested review from qw4990 and wshwsh12 November 29, 2021 08:33
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

@wjhuang2016 you're already a collaborator in bot's repo.

@wshwsh12 wshwsh12 removed their request for review January 11, 2022 07:01
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2022
@bb7133
Copy link
Member

bb7133 commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e9ca8ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8a3314a into pingcap:release-5.1 Feb 9, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

@wjhuang2016 wjhuang2016

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick

Projects

None yet

Milestone

v5.1.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @bb7133 @qw4990 @wjhuang2016 @zhouqiang-cl