Skip to content

types: fix wrong str_to_date() microseconds with leading zeros are not converted correctly (#30122)#30219

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-352811dfc4ee
Closed

types: fix wrong str_to_date() microseconds with leading zeros are not converted correctly (#30122)#30219
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-352811dfc4ee

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 29, 2021 •
edited
Loading

cherry-pick #30122 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30219

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30219:release-4.0-352811dfc4ee

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #30078

str_date doesn't parse microseconds correctly.

What is changed and how it works?

It's very easy. Not sure why it was wrong before.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016 @ti-srebot
cherry pick pingcap#30122 to release-4.0
72c5be6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 29, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 29, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 29, 2021
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/4.0-cherry-pick labels Nov 29, 2021
@ti-srebot ti-srebot requested review from qw4990 and wshwsh12 November 29, 2021 08:31
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 29, 2021

@wjhuang2016 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2021
@wshwsh12 wshwsh12 removed their request for review January 11, 2022 07:01
@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

close for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@wjhuang2016 wjhuang2016

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/4.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @xhebox @wjhuang2016