Skip to content

expression : prevent function DATE_ADD/SUB_STRING_XXX pushed down to TiFlash (#30154)#30160

Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.3from
ti-srebot:release-5.3-e15b76875d98
Closed

expression : prevent function DATE_ADD/SUB_STRING_XXX pushed down to TiFlash (#30154)#30160
ti-srebot wants to merge 2 commits intopingcap:release-5.3from
ti-srebot:release-5.3-e15b76875d98

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 25, 2021 •
edited
Loading

cherry-pick #30154 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30160

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30160:release-5.3-e15b76875d98

What problem does this PR solve?

temporary preventing function DATE_ADD/SUB_STRING_XXX pushed down to TiFlash because this function has some unsolvable
problems in TiFlash

Issue Number: close #30153

Release note

prevent function DATE_ADD/SUB_STRING_XXX pushed down to TiFlash

@mengxin9014 @ti-srebot
cherry pick pingcap#30154 to release-5.3
babad97 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 25, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 25, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.3-cherry-pick labels Nov 25, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 25, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 25, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 25, 2021

@mengxin9014 you're already a collaborator in bot's repo.

@windtalker
Copy link
Contributor

windtalker commented Nov 25, 2021

/run-check_dev

@mengxin9014
Copy link
Contributor

mengxin9014 commented Nov 25, 2021

/run-check_dev

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 15, 2022

/run-check_dev
@mengxin9014 please remember to continue this work. A new version is about to release. Thanks!

@LittleFall LittleFall removed their request for review July 25, 2022 10:47
@mengxin9014
Copy link
Contributor

mengxin9014 commented Nov 24, 2022

/close

@ti-chi-bot ti-chi-bot closed this Nov 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022

@mengxin9014: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@mengxin9014 mengxin9014

Labels

do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.3-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @windtalker @mengxin9014 @guo-shaoge