br: fix S3 backup endpoint suffix /#30144
br: fix S3 backup endpoint suffix /#30144tongtongyin wants to merge 4 commits intopingcap:masterfrom tongtongyin:master
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| options.Endpoint = strings.Trim(options.Endpoint, "/") |
There was a problem hiding this comment.
| options.Endpoint = strings.Trim(options.Endpoint, "/") | |
| options.Endpoint = strings.TrimSuffix(options.Endpoint, "/") |
| package ddl_test | ||
|
|
||
| import ( | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
[2021-11-30T08:07:27.397Z] ddl/options_test.go:18: File is not `goimports`-ed (goimports)
[2021-11-30T08:07:27.397Z] "github.com/stretchr/testify/require"
let's not do the test-infra migration in this PR.
There was a problem hiding this comment.
Here we try to get flag s3.endpoint, what if -s "s3://bank/shenma-without-stats?access-key=admin&secret-access-key=Passadmin&endpoint=http://minio.pingcap.net:9000/&force-path-style=true"
|
@tongtongyin: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I resubmitted a PR and closed the current one |
What problem does this PR solve?
Issue Number: close #30128
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note