Skip to content

expression: fix wrong flen for CastAsString funtion (#29563)#30056

Merged
ti-chi-bot merged 5 commits intopingcap:release-5.1from
ti-srebot:release-5.1-8858592f7eae
Sep 20, 2022
Merged

expression: fix wrong flen for CastAsString funtion (#29563)#30056
ti-chi-bot merged 5 commits intopingcap:release-5.1from
ti-srebot:release-5.1-8858592f7eae

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 23, 2021 •
edited
Loading

cherry-pick #29563 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30056

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30056:release-5.1-8858592f7eae

What problem does this PR solve?

Issue Number: close #29513

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix wrong flen for CastAsString funtion

@wshwsh12 @ti-srebot
cherry pick pingcap#29563 to release-5.1
4d59ab4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 23, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Nov 23, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 23, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 23, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 23, 2021

@wshwsh12 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 21, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 28, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3009052a6d00968f5adf36cb03fd98b529cfd6c3

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2022
@zanmato1984
Copy link
Contributor

zanmato1984 commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022

@zanmato1984: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zanmato1984
zanmato1984 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2022
@zanmato1984
Copy link
Contributor

zanmato1984 commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2b94181

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6f5abf6 into pingcap:release-5.1 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@winoros winoros Awaiting requested review from winoros

Assignees

@wshwsh12 wshwsh12

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.1-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @sre-bot @zanmato1984 @XuHuaiyu @VelocityLight @wshwsh12