Skip to content

server: fix bug https://asktug.com/t/topic/213082/11 (#29577)#30046

Merged
ti-chi-bot merged 6 commits intopingcap:release-5.2from
ti-srebot:release-5.2-0f86a53d419c
Apr 12, 2022
Merged

server: fix bug https://asktug.com/t/topic/213082/11 (#29577)#30046
ti-chi-bot merged 6 commits intopingcap:release-5.2from
ti-srebot:release-5.2-0f86a53d419c

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 23, 2021 •
edited
Loading

cherry-pick #29577 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30046

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30046:release-5.2-0f86a53d419c

What problem does this PR solve?

Issue Number: close #29709

See also https://asktug.com/t/topic/213082/11

Problem Summary:

Too much logs about auth plugin after upgrade tidb v5.2.2
[WARN] [conn.go:698] [“failed to check the user authplugin”] [conn=599967] [error=“Failed to get user record”]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

- Fix the bug that TiDB logs many `failed to check the user authplugin` when a user connects to TiDB.

@zgcbj @ti-srebot
cherry pick pingcap#29577 to release-5.2
5974d61 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 23, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 23, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 23, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 23, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 23, 2021

@djshow832 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2021
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
@winoros
Copy link
Member

winoros commented Apr 12, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 08a7c73

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b2c25935d1c9d7b440a20144bce4685740cadbe2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 16944f1 into pingcap:release-5.2 Apr 12, 2022
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.2, v5.2.4 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dveeden dveeden dveeden approved these changes

@djshow832 djshow832 djshow832 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@djshow832 djshow832

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick

Projects

None yet

Milestone

v5.2.4

Development

Successfully merging this pull request may close these issues.

9 participants

@ti-srebot @ti-chi-bot @winoros @sre-bot @dveeden @djshow832 @VelocityLight @zhouqiang-cl @zgcbj