Skip to content

expression: use encode buffer in to_binary, warp encrypt function with to_binary#29950

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:refactor-enc-func
Nov 22, 2021
Merged

expression: use encode buffer in to_binary, warp encrypt function with to_binary#29950
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:refactor-enc-func

Conversation

@unconsolable
Copy link
Contributor

@unconsolable unconsolable commented Nov 20, 2021

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: ref #29863

What is changed and how it works?

  • Introduce an encode buffer in (*builtinInternalToBinarySig) vecEvalString
  • Warp several encrypt function with to_binary
  • Update new_character_set_builtin.result because there is an inconsistency between vectorization and scalar function

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2021
@unconsolable
expression: use encode buffer in to_binary, warp encrypt function wit…
53b3fdb 
…h to_binary

Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable unconsolable marked this pull request as ready for review November 20, 2021 05:01
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 20, 2021

@unconsolable: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @tangenta @xiongjiwei @zimulala PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tangenta
tangenta approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2021
@Defined2014 Defined2014 mentioned this pull request Nov 22, 2021
Merged
12 tasks
zimulala
zimulala approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2021
@zimulala
Copy link
Contributor

zimulala commented Nov 22, 2021

/LGTM

@unconsolable
Copy link
Contributor Author

unconsolable commented Nov 22, 2021

/assign @zimulala
Please help on merge, thanks.

@tangenta
Copy link
Contributor

tangenta commented Nov 22, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 53b3fdb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@tangenta tangenta mentioned this pull request Nov 22, 2021
Merged
4 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e47f0f5 into pingcap:master Nov 22, 2021
@unconsolable unconsolable deleted the refactor-enc-func branch November 22, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@tangenta tangenta tangenta approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees

@zimulala zimulala

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unconsolable @ti-chi-bot @zimulala @tangenta