Skip to content

executor: fix drop role failed after revoke role from current user#29814

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:issue-29781
Nov 19, 2021
Merged

executor: fix drop role failed after revoke role from current user#29814
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:issue-29781

Conversation

@unconsolable
Copy link
Contributor

@unconsolable unconsolable commented Nov 15, 2021 •
edited
Loading

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #29781

Problem Summary:

What is changed and how it works?

Seems a follow-up of #29494

  • When an active role of current user is revoked, remove it from activeRoles.
  • Add unit test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@unconsolable
executor: fix drop role failed after revoke role from current user
3fa55ff 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2021
@unconsolable
try fix panic
7240202 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable unconsolable marked this pull request as ready for review November 15, 2021 13:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2021
@unconsolable
Copy link
Contributor Author

unconsolable commented Nov 15, 2021 •
edited
Loading

Although it still fails on common-test, it seems that the failure in [role] is resolved.
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_common_test/detail/tidb_ghpr_common_test/7350/pipeline/86
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_common_test/detail/tidb_ghpr_common_test/7351/pipeline/86

[2021-11-15T13:26:16.159Z] time="2021-11-15T21:26:16+08:00" level=error msg="1 tests failed\n"
[2021-11-15T13:26:16.159Z] time="2021-11-15T21:26:16+08:00" level=error msg="run test [update] err: sql:create table t2 (id int unsigned not null auto_increment primary key, a int);: run \"create table t2 (id int unsigned not null auto_increment primary key, a int);\" at line 148 err Error 1050: Table 'test.t2' already exists"

@ti-chi-bot ti-chi-bot requested review from mjonss and morgo November 15, 2021 13:32
@unconsolable unconsolable mentioned this pull request Nov 15, 2021
Merged
12 tasks
mjonss
mjonss reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a few questions :)

@unconsolable
compare cur user and host, refine test
59450e6 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
mjonss
mjonss approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for reporting the new bug too!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2021
@xhebox
Copy link
Contributor

xhebox commented Nov 19, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fa04b39

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2021
@ti-chi-bot ti-chi-bot merged commit 9843ff9 into pingcap:master Nov 19, 2021
@unconsolable unconsolable deleted the issue-29781 branch November 19, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@mjonss mjonss mjonss approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drop role failed after revoke role from current user

4 participants

@unconsolable @ti-chi-bot @xhebox @mjonss