util/chunk: avoid reuse duplicated chunk column in the pool#29809
util/chunk: avoid reuse duplicated chunk column in the pool#29809ti-chi-bot merged 3 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| // freeList is defined as a map, rather than a list, because when recycling chunk | ||
| // columns, there could be duplicated one: some of the chunk columns are just the | ||
| // reference to the others. | ||
| type freeList map[*Column]struct{} |
There was a problem hiding this comment.
Does this map affects the performance improvements?
There was a problem hiding this comment.
It's allocated once and reused...
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 5ee2866 |
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #29554 and pingcap/tiflash#3406
Problem Summary:
What is changed and how it works?
Not all the chunk columns are allocated, some are just reference to other columns.
For example, here the second column is the same with the third column, and the fourth column is even a reference to another chunk column:
So when we recycle the chunk column for reuse, we must deduplication to avoid introduce the same chunk column to the pool twice. The old array is changed to a map.
Check List
Tests
Side effects
Documentation
Release note