ddl : ddl forbid create / add / rename /drop index for cache table #29707
ddl : ddl forbid create / add / rename /drop index for cache table #29707ti-chi-bot merged 7 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| if err != nil || tblInfo == nil { | ||
| return ver, errors.Trace(err) | ||
| } | ||
| if tblInfo.TableCacheStatusType != model.TableCacheStatusDisable { |
There was a problem hiding this comment.
Better to check it before schedule to avoid unnecessary job
|
/run-check_dev_2 |
| return errors.Trace(err) | ||
| } | ||
|
|
||
| if t.Meta().TableCacheStatusType != model.TableCacheStatusDisable { |
There was a problem hiding this comment.
I think we should do checking both before and in schedule.
There was a problem hiding this comment.
you mean is double check?
|
/cc @tiancaiamao |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 448131c |
|
/ruh-check_dev |
|
/run-check_dev |
1 similar comment
|
/run-check_dev |
Issue Number: close #29659
Problem Summary:
This is a subtask of #25293
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note