Skip to content

table/tables: make CI stable for table/tables package#29688

Merged
lcwangchao merged 2 commits intopingcap:masterfrom
tiancaiamao:ci-fix
Nov 11, 2021
Merged

table/tables: make CI stable for table/tables package#29688
lcwangchao merged 2 commits intopingcap:masterfrom
tiancaiamao:ci-fix

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 11, 2021

What problem does this PR solve?

Issue Number: close #29632

Problem Summary:

What is changed and how it works?

Make CI stable

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2021
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Nov 11, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bc87b3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Nov 11, 2021

#25642

[2021-11-11T06:57:00.615Z] prepare_test.go:2129
[2021-11-11T06:57:00.615Z]     tk.MustQuery(`select @@last_plan_from_cache`).Check(testkit.Rows("1"))
[2021-11-11T06:57:00.615Z] /home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:67:
[2021-11-11T06:57:00.615Z]     res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
[2021-11-11T06:57:00.615Z] ... obtained string = "[0]\n"
[2021-11-11T06:57:00.615Z] ... expected string = "[1]\n"
[2021-11-11T06:57:00.615Z] ... sql:select @@last_plan_from_cache, args:[]
[2021-11-11T06:57:00.615Z] 
[2021-11-11T06:57:00.615Z] 
[2021-11-11T06:57:00.615Z] ----------------------------------------------------------------------

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Nov 11, 2021

/merge

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Nov 11, 2021

#24679

[2021-11-11T07:11:49.827Z] FAIL: handle_test.go:960: testSerialStatsSuite.TestAnalyzeGlobalStatsWithOpts2
[2021-11-11T07:11:49.827Z] 
[2021-11-11T07:11:49.827Z] handle_test.go:971:
[2021-11-11T07:11:49.827Z]     s.checkForGlobalStatsWithOpts(c, tk, "test_gstats_opt2", "p1", 1, 50)
[2021-11-11T07:11:49.827Z] handle_test.go:916:
[2021-11-11T07:11:49.827Z]     // since the hist-building algorithm doesn't stipulate the final bucket number to be equal to the expected number exactly,
[2021-11-11T07:11:49.827Z]     // we have to check the results by a range here.
[2021-11-11T07:11:49.827Z]     c.Assert(numBuckets, GreaterEqual, buckets-delta)
[2021-11-11T07:11:49.827Z] ... compare_one int = 0
[2021-11-11T07:11:49.827Z] ... compare_two int = 15

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Nov 11, 2021

/run-check_dev_2

@lcwangchao lcwangchao merged commit 00d0f14 into pingcap:master Nov 11, 2021
@tiancaiamao tiancaiamao deleted the ci-fix branch November 11, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@winoros winoros winoros approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test hang at package table/tables

5 participants

@tiancaiamao @ti-chi-bot @guo-shaoge @winoros @lcwangchao