ddl : support alter table xx nocache operations switch a table into uncacheable#29621
ddl : support alter table xx nocache operations switch a table into uncacheable#29621ti-chi-bot merged 12 commits intopingcap:masterfrom
alter table xx nocache operations switch a table into uncacheable#29621Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
alter table xx nocache operationsalter table xx nocache operations
alter table xx nocache operationsalter table xx nocache operations switch a table into uncacheable
|
/run-check_title |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 89845df |
|
/run-check_dev_2 |
1 similar comment
|
/run-check_dev_2 |
Co-authored-by: tangenta <tangenta@126.com>
|
/run-check_dev_2 |
|
/run-check_dev_2 |
ddl/db_cache_test.go
Outdated
| tk2 := testkit.NewTestKit(c, s.store) | ||
| tk.MustExec("use test") | ||
| tk.MustExec("drop table if exists nocache_t1") | ||
| tk2.MustExec("use test") |
There was a problem hiding this comment.
sorry. don't need tk2 here.
|
My pr encountered ci. Already resolved in this pr #29443 |
|
@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@jayl-zxl: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
handle DDL schema changes when a table is set to uncachable , we use synatx
alter table xx nocacheto switch a cacheable table to uncachable table.Issue number: close #29645
Problem Summary:
This is a subtask in #25293
What is changed and how it works?
support switch a cachable table to uncachable operation. and do some compatibility check with other feature.
ALTER TABLE t NOCACHEis a DDL operation. for consistency under distributed conditions. an intermediate Switching state is introduced, the schema change process is similar to the table lock implementation:Enabled => Switching => Disabled
Check List
Tests
Release note