Skip to content

expression: support GBK for builtin function SHA1/SHA2#29544

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:support_gbk_for_sha1_sha2
Nov 8, 2021
Merged

expression: support GBK for builtin function SHA1/SHA2#29544
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:support_gbk_for_sha1_sha2

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 8, 2021 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #29356

close #29355

Problem Summary:

support GBK for builtin function SHA1/SHA2

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2021
@hawkingrei hawkingrei force-pushed the support_gbk_for_sha1_sha2 branch 2 times, most recently from 8cd3ca6 to 0380373 Compare November 8, 2021 06:33
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2021
@hawkingrei hawkingrei force-pushed the support_gbk_for_sha1_sha2 branch 2 times, most recently from 698a24d to 9f43b52 Compare November 8, 2021 06:46
@hawkingrei hawkingrei changed the title [WIP] expression: support GBK for builtin function SHA1/SHA2 expression: support GBK for builtin function SHA1/SHA2 Nov 8, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@hawkingrei
Copy link
Member Author

hawkingrei commented Nov 8, 2021

/run-check_dev_2

@hawkingrei
Copy link
Member Author

hawkingrei commented Nov 8, 2021

@xiongjiwei @zimulala PTAL

@hawkingrei
expression: support GBK for builtin function SHA1/SHA2
98be72e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the support_gbk_for_sha1_sha2 branch from 9f43b52 to 98be72e Compare November 8, 2021 08:07
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2021
@AilinKid
Copy link
Contributor

AilinKid commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9076842

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot ti-chi-bot merged commit a14ad60 into pingcap:master Nov 8, 2021
@hawkingrei hawkingrei deleted the support_gbk_for_sha1_sha2 branch November 8, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support GBK for builtin function SHA2 Support GBK for builtin function SHA1

4 participants

@hawkingrei @ti-chi-bot @AilinKid @wjhuang2016