ddl: make CI TestDropSchemaWithPartitionTable stable#29499
ddl: make CI TestDropSchemaWithPartitionTable stable#29499ti-chi-bot merged 3 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| // Takes too long, give up the check. | ||
| logutil.BgLogger().Info("drop schema", | ||
| zap.Int64("id", tableIDs[0]), | ||
| zap.Stringer("duration", time.Since(startTime)), |
There was a problem hiding this comment.
TODO: for async test, the wait time is underestimated/uncontrollable when the CI is with a high workload. Better way is to sync it or move it out of unit tests.
There was a problem hiding this comment.
Agree, in my local env, it's fast and never run here.
When it's slow in CI and fails, the log is helpful for debugging.
There was a problem hiding this comment.
Can not we set the logging as Debug ?
There was a problem hiding this comment.
Hey, buddy, don't be too serious... it's the test code and never affect the user. @xhebox
The default loglevel in CI is not set to Debug, so if it really happen we will miss the information.
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 930bab2 |
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #28206
Problem Summary:
Fix a unstable test
What is changed and how it works?
Wait the gc_delete_range work finish before check the data removed
Check List
Tests
Side effects
Documentation
Release note