plan,table : support write operator for cache table and mock lockwrite state#29444
plan,table : support write operator for cache table and mock lockwrite state#29444ti-chi-bot merged 47 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
table/tables/cache.go
Outdated
| c.mu.Lock() | ||
| defer c.mu.Unlock() |
There was a problem hiding this comment.
If loadDataFromOriginalTable not a method and only depends on sessionctx.Context
c.cacheData is a atomic Value,
c.handle don't write to a internal state,
Then UpdateLockForRead is thread safe and don't need this lock.
There was a problem hiding this comment.
Do some heavy things under a lock (network here e.g), the lock will block for a long time if conflicts.
There was a problem hiding this comment.
you are right. i will remove it
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: bb65656 |
|
@jayl-zxl: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-check_dev_2 |
…te_and_mock_state
…l/tidb into dml_write_and_mock_state
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3748f4f |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
This is a subtask of #25293
What is changed and how it works?
Check List
Tests
Release note