expression: support builtin func password for GBK#29202
expression: support builtin func password for GBK#29202ti-chi-bot merged 6 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/cc @zimulala @tangenta @wjhuang2016 |
parser/auth/mysql_native_password.go
Outdated
There was a problem hiding this comment.
add a new function here to reduce memcpy when []byte to string
There was a problem hiding this comment.
Is it the same as MySQL 5.7?
There was a problem hiding this comment.
tried on http://sqlfiddle.com/ which is MySQL 5.6. The result is same.
There was a problem hiding this comment.
tried on https://www.db-fiddle.com/ with MySQL 5.7. It also worked.
478615c to
683f6b8
Compare
|
/cc @AilinKid |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 92328fd |
|
@Defined2014: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-check_dev_2 |
2 similar comments
|
/run-check_dev_2 |
|
/run-check_dev_2 |
What problem does this PR solve?
Issue Number: close #29092
Problem Summary: support builtin func password for GBK
What is changed and how it works?
Check List
Tests
Release note