expression: Support GBK for builtin function MD5#29165
expression: Support GBK for builtin function MD5#29165ti-chi-bot merged 8 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/cc @xiongjiwei @tangenta |
|
/run-check_dev_2 |
|
/cc @zimulala |
expression/builtin_encryption.go
Outdated
There was a problem hiding this comment.
Do we have a test for this logic?
There was a problem hiding this comment.
No, we will not go to this branch in TiDB normal use, because of #28778. If it's necessary, I will add it.
There was a problem hiding this comment.
And a question here, need I add a warning log when get invalid character here?
There was a problem hiding this comment.
@hawkingrei #29314 will handle this problem uniformly? Maybe we can return an error or a panic？
There was a problem hiding this comment.
@hawkingrei #29314 will handle this problem uniformly? Maybe we can return an error or a panic？
OK, I will.
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3c5c29f |
|
@Defined2014: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-check_dev_2 |
|
/run-build |
|
/run-check_dev_2 |
What problem does this PR solve?
Issue Number: close #29090
Problem Summary: Support GBK for builtin function MD5
What is changed and how it works?
Check List
Tests
Release note