Skip to content

ddl: use the individual infosyncer for each attributes test#28898

Merged
ti-chi-bot merged 8 commits intopingcap:masterfrom
rleungx:stable-test
Nov 15, 2021
Merged

ddl: use the individual infosyncer for each attributes test#28898
ti-chi-bot merged 8 commits intopingcap:masterfrom
rleungx:stable-test

Conversation

@rleungx
Copy link
Member

@rleungx rleungx commented Oct 18, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: Trying to fix #27892, fix #28020, and fix #29734

Problem Summary: There are some unstable tests in region label testing.

What is changed and how it works?

What's Changed: This PR is trying to make the tests stable by using the individual infosyncer for each attributes test. Also, the PR renames the table names so that we can locate the problem easier.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2021
@rleungx
Copy link
Member Author

rleungx commented Oct 18, 2021

/cc @djshow832

@ti-chi-bot ti-chi-bot requested a review from djshow832 October 18, 2021 03:41
@djshow832
Copy link
Contributor

djshow832 commented Oct 20, 2021

It seems that you are not sure about the reason, right?

@rleungx
Copy link
Member Author

rleungx commented Oct 21, 2021 •
edited
Loading

It seems that you are not sure about the reason, right?

Right, this PR is just trying to fix but I'm not quite sure if it works.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2021
@rleungx
use individual infosyncer for attributes tests
5f138fc 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
resolve conflicts
bb90d54 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021
@rleungx
use serial suites
bb27087 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2021
@rleungx
Copy link
Member Author

rleungx commented Nov 12, 2021

/cc @Yisaer @xhebox

@ti-chi-bot ti-chi-bot requested review from Yisaer and xhebox November 12, 2021 11:20
@rleungx
Copy link
Member Author

rleungx commented Nov 12, 2021

I'm going to use SerialSuites for these attributes tests. @djshow832

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

@Defined2014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@bb7133
Copy link
Member

bb7133 commented Nov 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5318eb8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@Defined2014
Copy link
Contributor

Defined2014 commented Nov 15, 2021

/run-check_dev_2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 79e6d1b into pingcap:master Nov 15, 2021
@rleungx rleungx deleted the stable-test branch November 15, 2021 06:37
@Defined2014 Defined2014 mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

6 participants

@rleungx @ti-chi-bot @djshow832 @bb7133 @Defined2014 @xhebox