Skip to content

executor: support GRANT/REVOKE ON non-existent table#28882

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:issue-28533
Oct 19, 2021
Merged

executor: support GRANT/REVOKE ON non-existent table#28882
ti-chi-bot merged 4 commits intopingcap:masterfrom
unconsolable:issue-28533

Conversation

@unconsolable
Copy link
Contributor

@unconsolable unconsolable commented Oct 15, 2021

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #28533

What is changed and how it works?

What's Changed:

  • In GrantExec, err won't be return if equals to infoschema.ErrTableNotExists
  • In RevokeExec, err won't be return if equals to infoschema.ErrTableNotExists, and tblName will be got from executor if tbl == nil
  • In getTargetSchemaAndTable, return dbName for error infoschema.ErrTableNotExists

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

support GRANT/REVOKE ON non-existent table

@unconsolable
executor: support GRANT/REVOKE ON non-existent table
d6e3199 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2021
@ti-chi-bot ti-chi-bot requested a review from morgo October 15, 2021 14:26
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2021
@morgo morgo requested review from mjonss and tiancaiamao October 18, 2021 14:05
mjonss
mjonss approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions on more stable tests.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2021
unconsolable and others added 2 commits October 19, 2021 00:28
@unconsolable @mjonss
test cleanup
bda9e3e 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@unconsolable
executor: update test cleanup
1ec4d5d 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@morgo
Copy link
Contributor

morgo commented Oct 19, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1ec4d5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5559078 into pingcap:master Oct 19, 2021
@unconsolable unconsolable deleted the issue-28533 branch October 19, 2021 03:49
@unconsolable unconsolable mentioned this pull request Oct 31, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgo morgo morgo approved these changes

@mjonss mjonss mjonss approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

@morgo morgo

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GRANT/REVOKE ON non-existent table incorrectly returns error

4 participants

@unconsolable @ti-chi-bot @morgo @mjonss