Skip to content

test: implement ShortCircuitForBench#28732

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
tisonkun:issue-28709
Oct 12, 2021
Merged

test: implement ShortCircuitForBench#28732
ti-chi-bot merged 2 commits intopingcap:masterfrom
tisonkun:issue-28709

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 11, 2021

This closes #28709 .

Release note

None

@tisonkun
test: implement ShortCircuitForBench
566784c 
This closes pingcap#28709 .

Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 11, 2021

/cc @disksing @tiancaiamao

@tiancaiamao please verify this patch with your benchmark settings.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2021
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Oct 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 566784c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5a4ee31 into pingcap:master Oct 12, 2021
@tisonkun tisonkun deleted the issue-28709 branch October 12, 2021 08:56
@tiancaiamao tiancaiamao mentioned this pull request Oct 14, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@disksing disksing disksing approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid testing setup for benchmarks

4 participants

@tisonkun @ti-chi-bot @tiancaiamao @disksing