Skip to content

types: migrate test-infra to testify for fsp_test.go#28044

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
myccccccc:issue28006
Sep 15, 2021
Merged

types: migrate test-infra to testify for fsp_test.go#28044
ti-chi-bot merged 6 commits intopingcap:masterfrom
myccccccc:issue28006

Conversation

@myccccccc
Copy link
Contributor

@myccccccc myccccccc commented Sep 14, 2021

What problem does this PR solve?

Issue Number: close #28006

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 14, 2021
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2021
@myccccccc
Copy link
Contributor Author

myccccccc commented Sep 14, 2021

/cc @tisonkun @mmyj

@ti-chi-bot ti-chi-bot requested review from mmyj and tisonkun September 14, 2021 12:56
mmyj
mmyj reviewed Sep 14, 2021
View reviewed changes
mmyj
mmyj reviewed Sep 14, 2021
View reviewed changes
karuppiah7890
karuppiah7890 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@karuppiah7890 karuppiah7890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021

@karuppiah7890: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM! :D

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

mmyj
mmyj approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
tisonkun
tisonkun approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @myccccccc ! LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Sep 15, 2021

/assign @mmyj

@mmyj
Copy link
Member

mmyj commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 56a896d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

@myccccccc: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fd206f4 into pingcap:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

@mmyj mmyj mmyj approved these changes

+1 more reviewer

@karuppiah7890 karuppiah7890 karuppiah7890 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmyj mmyj

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for fsp_test.go

6 participants

@myccccccc @ti-chi-bot @tisonkun @mmyj @karuppiah7890 @ti-srebot