Skip to content

executor: support selecting store by tidb_replica_read for stale read#28033

Merged
ti-chi-bot merged 12 commits intopingcap:masterfrom
Yisaer:support_stale_router
Sep 15, 2021
Merged

executor: support selecting store by tidb_replica_read for stale read#28033
ti-chi-bot merged 12 commits intopingcap:masterfrom
Yisaer:support_stale_router

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Sep 14, 2021

What is changed and how it works?

Add an extra value choice closest-replicas for tidb_replica_read and make follower read and stale read can be affected by tidb_replica_read with same behavior.

Check List

Tests

  • Unit test

Release note 

None

Yisaer added 10 commits September 13, 2021 16:35
@Yisaer
rename txnScope as readReplicaScope
3902ec6 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
rename txnScope as readReplicaScope
6f22c56 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
rename txnScope as readReplicaScope
83a7242 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix test
711b925 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
aa972ff 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
1da8ce1 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix test
b21bf40 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge branch 'master' of https://github.com/pingcap/tidb into support…
6d5cf73 
…_stale_router
@Yisaer
add test
6beea42 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Update sysvar.go
dfbec5a
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2021
JmPotato
JmPotato reviewed Sep 15, 2021
View reviewed changes
executor/stale_txn_test.go Outdated
}

func (s *testStaleTxnSerialSuite) TestStaleReadKVRequest(c *C) {
//c.Skip("tmp skip")
Copy link
Member

@JmPotato JmPotato Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commenting this line?

Copy link
Contributor

@xhebox xhebox Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems useless.

Copy link
Contributor Author

@Yisaer Yisaer Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

xhebox
xhebox approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

executor/stale_txn_test.go Outdated
}

func (s *testStaleTxnSerialSuite) TestStaleReadKVRequest(c *C) {
//c.Skip("tmp skip")
Copy link
Contributor

@xhebox xhebox Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems useless.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@Yisaer
address the comment
b92e73e 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b92e73e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f710f3d into pingcap:master Sep 15, 2021
@morgo morgo mentioned this pull request Oct 1, 2021
Merged
12 tasks
@glorv glorv mentioned this pull request Jul 4, 2022
Open
@glorv glorv mentioned this pull request Jul 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@xhebox xhebox xhebox approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yisaer @ti-chi-bot @JmPotato @xhebox